Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Coturn brokering #982

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Remove Coturn brokering #982

merged 1 commit into from
Nov 12, 2023

Conversation

Brutus5000
Copy link
Member

This featured has been moved to a dedicated API.

@Brutus5000 Brutus5000 force-pushed the feature/remove-coturn branch from ab79850 to fd14811 Compare November 4, 2023 18:05
@Brutus5000 Brutus5000 marked this pull request as ready for review November 4, 2023 18:36
Copy link
Collaborator

@Askaholic Askaholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the Pipfile.lock actually needs to be updated. I think that happened because of the changes you made when you removed twilio. I can fix it up for you though.

integration_tests/test_server.py Show resolved Hide resolved
Base automatically changed from feature/remove-twilio to develop November 5, 2023 19:40
@Brutus5000 Brutus5000 force-pushed the feature/remove-coturn branch 2 times, most recently from 3a1c55a to 1a37316 Compare November 5, 2023 19:55
@Askaholic Askaholic force-pushed the feature/remove-coturn branch from 1a37316 to 17ab8b3 Compare November 12, 2023 21:21
@Askaholic Askaholic merged commit ca1bd38 into develop Nov 12, 2023
8 checks passed
@Askaholic Askaholic deleted the feature/remove-coturn branch November 12, 2023 21:28
Gatsik added a commit to Gatsik/client that referenced this pull request May 14, 2024
* launch it with java.exe from jre
* pass required game_id argument
* fetch ice_servers from api and don't expect them from the server
(see FAForever/server#982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants